Put detector in navigator_state #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tector-into-state
|
@niermann999 PR is ready |
niermann999
approved these changes
Sep 27, 2022
| vector_type<intersection_type> candidates) | ||
| : _detector(&det), _candidates(candidates) {} | ||
|
|
||
| /// Scalar representation of the navigation state, |
There was a problem hiding this comment.
Could you please update the comments?
| @@ -410,8 +414,9 @@ class navigator { | |||
| DETRAY_HOST_DEVICE inline bool init(propagator_state_t &propagation) const { | |||
|
|
|||
| state &navigation = propagation._navigation; | |||
| const auto &det = navigation.detector(); | |||
There was a problem hiding this comment.
Does this return a reference to a pointer? I am wondering, does simply using const auto make things easier or does that break something?
There was a problem hiding this comment.
You are right :p That was dumb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #291
This PR moves detector pointer from navigator to its state