Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Updates, main branch (2023.10.09.) #564

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

krasznaa
Copy link
Member

@krasznaa krasznaa commented Oct 9, 2023

Updated some externals for (better) Windows/CMake compatibility.

  • The updated VecMem version provides SYCL support on Windows with CMake 3.27+;
  • The updated GoogleTest version avoids a warning with CMake 3.27+;
  • The updated Covfie version removes GCC specific hardcodes that prevented a build on Windows.

This is all in a prelude for things to come... 👻

Copy link
Collaborator

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krasznaa krasznaa merged commit 73f0446 into acts-project:main Oct 9, 2023
16 checks passed
@krasznaa krasznaa deleted the ExternalUpdates-main-20231009 branch October 9, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants