feat: Implement surface lookup from source link #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
force-pushed
the
feat-new-sf-lookup
branch
8 times, most recently
from
f981d0b to
e21c1ec
Compare
niermann999
force-pushed
the
feat-new-sf-lookup
branch
3 times, most recently
from
196b9ab to
9bff1e6
Compare
niermann999
force-pushed
the
feat-new-sf-lookup
branch
4 times, most recently
from
eefb871 to
94ce91a
Compare
niermann999
added
enhancement
|
Most of the changes in the detector are from reordering the methods, so that it becomes clear which ones are up for removal |
niermann999
force-pushed
the
feat-new-sf-lookup
branch
from
8a79017 to
2b915c8
Compare
niermann999
force-pushed
the
feat-new-sf-lookup
branch
9 times, most recently
from
2e89e27 to
6a96e9c
Compare
niermann999
force-pushed
the
feat-new-sf-lookup
branch
9 times, most recently
from
80aeb02 to
8559685
Compare
|
I need this PR for the grid builder, so that I can use the index offsets in the volume descriptors to switch between global and local indices in the grids |
niermann999
force-pushed
the
feat-new-sf-lookup
branch
from
8559685 to
198fd32
Compare
|
With some help from @beomki-yeo , I also hot-fixed another division by zero and added some asserts |
… can be extended later on without breaking anything. The surface lookup is renamed to just surfaces again. It also strips the source link from the surface descriptor, which will now not be carried around throughout all of the navigation and grid. The source link is still available via the surface lookup. In order to make easier lookups for the source links, the portal, sensisitve and passive index ranges are added back to the volume descriptor, which also allows to get access to the surface range of a volume via the detector_volume class. Wherever I could find it, I already refactored the surface access through the volume accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This abstracts the surface lookup from the detector class, so that it can be extended later on without breaking anything. The surface lookup is renamed to just surfaces again. It also strips the source link from the surface descriptor, which will now not be carried around throughout all of the navigation and grid. The source link is still available via the surface lookup.
In order to make easier lookups for the source links, the portal, sensisitve and passive index ranges are added back to the volume descriptor, which also allows to get access to the surface range of a volume via the
detector_volumeclass. Wherever I could find it, I already refactored the surface access through the volume accordingly.