ref: Add centroid approximation for (annulus) shape #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
added
bug
niermann999
force-pushed
the
fix-surface-center
branch
3 times, most recently
from
3379f75 to
d13463e
Compare
|
Not sure returning the global center position from a shape is the right approach, since the shape itself does everything in its local coordinate system and it is the surface that should do the transformation to global coordinates, but this way I can return the translation from the transform and don't have to transform point2{0., 0.} to global coordinates. |
Merged
beomki-yeo
reviewed
Nov 15, 2023
It has been in the core library before (but incorrect for the annulus shape). The main motivation for this PR was to use it in the Newton intersector, but I think now that it would also work without it |
niermann999
force-pushed
the
fix-surface-center
branch
4 times, most recently
from
a55c7cf to
6cd7b96
Compare
niermann999
changed the title
niermann999
force-pushed
the
fix-surface-center
branch
from
6cd7b96 to
303047d
Compare
beomki-yeo
approved these changes
Nov 16, 2023
niermann999
force-pushed
the
fix-surface-center
branch
3 times, most recently
from
a21b11b to
d3492bf
Compare
…approximationx for the annulus shape
niermann999
added
priority: low
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the calculation of the surface center position into the shapes and add an approximation for the annulus shape. Also uses the annulus center now in a few places and does some renaming for clarification in the helix intersectors.