Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use algebra concepts #902

Merged

Conversation

niermann999
Copy link
Contributor

@niermann999 niermann999 commented Dec 8, 2024

Use algebra-plugins concepts and update to patched algebra-plugins version. Also adds a few missing includes here and there.

@niermann999 niermann999 added enhancement New feature or request refactor refactoring the current codes priority: low Low priority labels Dec 8, 2024
@niermann999 niermann999 force-pushed the feat-use-algebra-concepts branch from 65d5b65 to 78191fa Compare December 9, 2024 00:16
@niermann999 niermann999 added the blocked This item is blocked by another item label Dec 9, 2024
@niermann999

This comment was marked as outdated.

@niermann999 niermann999 force-pushed the feat-use-algebra-concepts branch from 78191fa to 2ad62a1 Compare December 9, 2024 09:38
@niermann999 niermann999 removed the blocked This item is blocked by another item label Dec 18, 2024
@niermann999 niermann999 force-pushed the feat-use-algebra-concepts branch 3 times, most recently from b2d570a to 818c300 Compare December 18, 2024 16:11
@niermann999 niermann999 force-pushed the feat-use-algebra-concepts branch from 818c300 to 5b79d03 Compare December 19, 2024 10:47
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
6.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Collaborator

@beomki-yeo beomki-yeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@niermann999 niermann999 merged commit 2e41d90 into acts-project:main Dec 19, 2024
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: low Low priority refactor refactoring the current codes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants