-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: benchmark CLI tool #904
feat: benchmark CLI tool #904
Conversation
4558c20
to
e4423f1
Compare
3c71893
to
c9ca8c3
Compare
c9ca8c3
to
b3aa2a7
Compare
b3aa2a7
to
4020454
Compare
d3b6d27
to
5285eaf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for the most part, but I don't think we should be hardcoding architecure-related compile options; that should be left to the user to decide.
5285eaf
to
921c89b
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Call the benchmark tools from commandline using the detector reader and configure them using io options. In order to be able to configure the benchmarks the same way as the inbuilt benchmarks which are run for the continuous benchmark monitoring, new options for the random seed and track momentum ranges were added to the track generator options parsing.
Also adds a few small changes and fixes, eg:
true
for inbuilt benchmarksThis PR will make benchmarking the ODD and ITk possible