Use approximate equality checks for 3D point tests #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
reviewed
Dec 13, 2024
stephenswat
force-pushed
the
fix/near_point3_comparison
branch
from
17233ab to
b69bac7
Compare
|
Hah well spotted, thanks. |
|
Currently, we require exact equality on floating point 3D vectors, which is unreasonable. This commit changes the code such that the equality is instead defined with an epsilon value of 1E-6.
niermann999
reviewed
Dec 13, 2024
niermann999
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we require exact equality on floating point 3D vectors, which is unreasonable. This commit changes the code such that the equality is instead defined with an epsilon value of 1E-6.