Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUDA 12.6 + oneAPI 2025.0 Update, main branch (2024.11.28.) #128

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

krasznaa
Copy link
Member

Updated everything to CUDA 12.6 and oneAPI 2025.0. Since in my experience that's the combination working best with our latest GPU R&D code. 🤔

I have to admit, I didn't make a test build of every modified image locally. 🤔 So let's see how the CI does...

@krasznaa
Copy link
Member Author

😕 For some reason the CodePlay plugin download just doesn't work for the latest plugins... 😕

I'll debug it a bit further, but then we'll need to ask for help from them directly...

At the same time tweaked and harmonized how the NVIDIA and AMD
CodePlay plugins would be downloaded during the image build.
@krasznaa krasznaa force-pushed the GPULanguageUpdates-main-20241128 branch from 75de5e5 to fa3c9f3 Compare November 28, 2024 09:12
@krasznaa
Copy link
Member Author

It seems to have been 2 different problems for the 2 different plugins.

  • There are now both Linux and Windows plugins available for the NVIDIA backend with 2025.0, so the download needs to be more specific;
  • The version selection for the AMD plugins was set up in a super fancy, but not robust way. I changed it to do the same thing as the NVIDIA plugin. Taking a hardcoded version for the plugin version, instead of trying to smartly deduce it.
    • In the past there were a few cases where multiple plugin versions were released for the same oneAPI version. So this should be a lot more robust of a setup. 🤔

@stephenswat
Copy link
Member

  • In the past there were a few cases where multiple plugin versions were released for the same oneAPI version. So this should be a lot more robust of a setup. 🤔

Do you have an example of this? I don't love this new setup because it assumes that the CodePlay download API and the system package manager install the exact same patch version. If anything this new approach is less robust. 😕

@stephenswat stephenswat merged commit b67bbd8 into main Nov 28, 2024
16 checks passed
@stephenswat stephenswat deleted the GPULanguageUpdates-main-20241128 branch November 28, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants