Simulation Tweaks, main branch (2025.01.08.) #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
approved these changes
Jan 8, 2025
Made traccc::smearing_writer use std::filesystem for a little bit of additional robustness, and removed some awkwardness from the parameter passing in these classes.
krasznaa
force-pushed
the
SimulationTweak-main-20250108
branch
from
08c356b to
32db4cb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small improvements to the simulation code, taken from #773.
Made
traccc::smearing_writeruse std::filesystem for a little bit of additional robustness, and removed some awkwardness from the parameter passing in these classes.To be honest, I don't remember anymore why I did this in #773. I think it helped with the CKF tests writing their test files into a more reasonable location...? 😕
P.S. The two
const-ness changes are very much related to each other. I think the rvalue reference insmearing_writerwas added because of the missingconstinmeasurement_smearer. 🤔 Note that a copy is being made of the smearer no matter what. We just don't require a non-const original for the copy anymore.