Stream Handling Update, main branch (2025.01.10.) #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added a device_name() function to it as a quality-of-life improvement.
krasznaa
added
enhancement
Along with internal helper functions that would be needed for its implementation.
Also added additional functions to it as quality-of-life improvements.
krasznaa
force-pushed
the
StreamHandlingUpdate-main-20250110
branch
from
6b3ddd6 to
3854753
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was triggered by my recent experience in acts-project/traccc#811. That way more source files are implemented as
.cuand.syclfiles than strictly necessary. Mainly because of having to interact with the streams/queues in ways that is not supported by these helper classes.As long as I was updating the code, I also tried to modernise the classes a bit. With a slightly cleaner PIMPL implementation than what they use now.
Finally, I also added a
vecmem::hip::stream_wrapperclass, as a start to some effort in bringing HIP support on par with the CUDA and SYCL ones.