Skip to content

Commit

Permalink
Fix the flaky arbitrationAbort test (facebookincubator#11316)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: facebookincubator#11316

The doesn't require timeout setting and also only work for debug build

Reviewed By: amitkdutta, tanjialiang

Differential Revision: D64736824

fbshipit-source-id: 9b9d31fe51810f8ef84e6325a7d0d364b4677676
  • Loading branch information
xiaoxmeng authored and facebook-github-bot committed Oct 22, 2024
1 parent 005b52b commit f93eae6
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions velox/common/memory/tests/MockSharedArbitratorTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2219,10 +2219,9 @@ TEST_F(MockSharedArbitrationTest, ensureNodeMaxCapacity) {
}
}

TEST_F(MockSharedArbitrationTest, arbitrationAbort) {
DEBUG_ONLY_TEST_F(MockSharedArbitrationTest, arbitrationAbort) {
uint64_t memoryCapacity = 256 * MB;
setupMemory(
memoryCapacity, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1.0, nullptr, true, 1'000);
setupMemory(memoryCapacity);
std::shared_ptr<MockTask> task1 = addTask(memoryCapacity);
auto* op1 =
task1->addMemoryOp(true, [&](MemoryPool* /*unsed*/, uint64_t /*unsed*/) {
Expand Down

0 comments on commit f93eae6

Please sign in to comment.