Corrected action taken after successfully storing the fingerprint in enroll example. #69
Conversation
A return statement after succesfully storing the fingerprint was missing. Added a return value of 0. When the fingerprint is taken succesfully, the program should restart instead of continuing to take the fingerprint; amended. The program prints dots to indicate it is waiting, removed a newline being printed after each of these in one case.
Not missing, it's the
Yah, that's annoying. The second read loop doesn't do that. If this PR is still being monitored, please provide more info about the motivation for the added |
|
That |
|
Let me pull the latest to my branch, |
|
I'd still like the return in the if block more, because it is the only case in which that return is used, but that's a matter of preference. |
examples/enroll/enroll.ino
Outdated
| int error = 1; | ||
| while (error){ | ||
| error = getFingerprintEnroll(); | ||
| } |
There was a problem hiding this comment.
This is functionally equivalent. Why the change?
There was a problem hiding this comment.
It has been a long time. I think I changed it because it took me a long time to figure out what the original actually meant.
There was a problem hiding this comment.
OK, for now plz make the PR just the fix for the "." prints.
Rolling back code clarification.
|
Thanks. LGTM. |
A return statement after successfully storing the fingerprint was missing. Added a return value of 0.
When the fingerprint is taken successfully, the program should restart instead of continuing to take the fingerprint; amended.
The program prints dots to indicate it is waiting, removed a newline being printed after each of these in one case.