Lgpio native

[frank-pet]

Code changes to remove use of RPi.GPIO and replace with using the lgpio package directly. changes to:

1. microcontroller/bcm2711/pin.py
2. microcontroller/bcm283x/pin.py
3. microcontroller/bcm283x/pwmio/PWMOut.py

Changes have been tested and work on both a PI 5 and a Pi3b.

This is the fix for Issue #910

[makermelissa]

Overall, the changes in the PR look great and it appears you have done most of the hard stuff.

However, the bcm283x files are used by every single raspberry pi from Pi 1 through Pi 3B+ and I'd prefer to leave these alone as they seem to be fine. The bcm2811 files are used by Pi 4 and up and are probably safe to mess with. Because lgpio appears to be targeted more at linux and less at Raspberry Pis specifically, I would prefer to add new lgpio-specific pinfile to src/adafruit-blinka/microcontroller/generic_linux (something like lgpio_pin.py) so that they could be used by other boards in the future and maybe a copy of the PWMOut (with your changes) to the bcm2811 folder. Then only the bcm2811 files could just make use of those.

[makermelissa]

Also, if you wanted to test with the Raspberry Pi Zero (original), that would probably be pretty equivalent to the Original Raspberry Pi.

[frank-pet]

Just finished testing on a Pi zero w v1.1. changes work just fine. Took some effort since all my other projects are 64-bit machines; had to build a 32 bit image for this test...

[makermelissa]

Thank you. The main odd thing in your code that I see is:
In PWMOut, rather than importing board, why not have:
from adafruit_blinka.microcontroller.bcm283x.pin import Pin, CHIP

And then you can remove the unused import from bcm2711.

I want to do some testing myself (such as speed tests) and if it is similar (or faster). I may do some restructuring as well so that other boards could use the lgpio pin def as well. It will at least allow us to have some consistency this way.

[frank-pet]

That was a while ago, but probably because I didn’t want to stray too far from the other code in the package I was looking at…. Yours does sound like a better approach.Sent from my iPadOn Feb 5, 2025, at 5:07 PM, Melissa LeBlanc-Williams ***@***.***> wrote: Thank you. The main odd thing in your code that I see is: In PWMOut, rather than importing board, why not have: from adafruit_blinka.microcontroller.bcm283x.pin import Pin, CHIP And then you can remove the unused import from bcm2711. I want to do some testing myself (such as speed tests) and if it is similar (or faster). I may do some restructuring as well so that other boards could use the lgpio pin def as well. It will at least allow us to have some consistency this way. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>