fix: timeout datatype in haltError #690
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentru
requested changes
Feb 11, 2025
| @@ -2504,9 +2504,9 @@ void Wippersnapper::runNetFSM() { | |||
| void Wippersnapper::haltError(String error, ws_led_status_t ledStatusColor, | |||
| uint8_t seconds_until_reboot) { | |||
There was a problem hiding this comment.
Should seconds_until_reboot also be uint8_t?
| @@ -2504,9 +2504,9 @@ void Wippersnapper::runNetFSM() { | |||
| void Wippersnapper::haltError(String error, ws_led_status_t ledStatusColor, | |||
| uint8_t seconds_until_reboot) { | |||
| #ifdef ARDUINO_ARCH_ESP8266 | |||
| uint8_t wdt_timeout_ms = 3200; | |||
| uint16_t wdt_timeout_ms = 3200; | |||
There was a problem hiding this comment.
The function signature of enableWDTV2(int timeoutMS), which takes in this wdt_timeout_ms value is int not uint. Why are you changing it to uint16_t?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted while testing the DS18b20 (which has been fixed upstream)