try to address sys module #1070 #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hathach the issue was when doing an "ampy get" to a feather52832 . |
|
@jerryneedell just tested, seems to work with pca10056 board (too lazy to pull out feather52832 now :D ) I saw the text.txt is copied to my local disk. Hopefully this is good enough |
jerryneedell
approved these changes
Aug 1, 2018
There was a problem hiding this comment.
Tested changes on feathere52832 the "ampy get" issue scientifichackers/ampy#47 is resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1070
NOTE: please don't merge this yet since I haven't tested on the chip@jerryneedell it compiles but I don't know how to test it, if you could tell me, I will verify and update the PR
Update: ampy get works with pca10056, should work with feather52832 as well.