Upgrade json, restforce, and webmock to latest versions. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The versions of each of these had fallen a reasonable way behind mainline, which could cause issues when trying to depend on this code in more up-to-date codebases. There were 2 tests that I updated to make them more robust. The timeout one I made the queries explicit that were being mocked. There was another test that only worked up to the year 2020, so updating that to work until the year 3000. The newer versions of Faraday now use a ConnectionFailed error to indicate a timeout when opening the connection (lostisland/faraday#718), so updated accordingly. Restforce 5 requires ruby 2.5, so updated that requirement as well. Also updated the tests to point to the latest version of the API at time of writing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The versions of each of these had fallen a reasonable way behind mainline, which could cause issues when trying to depend on this code in more up-to-date codebases.
There were 2 tests that I updated to make them more robust. The timeout one I made the queries explicit that were being mocked. There was another test that only worked up to the year 2020, so updating that to work until the year 3000.
The newer versions of Faraday now use a ConnectionFailed error to indicate a timeout when opening the connection (lostisland/faraday#718), so updated accordingly.
Restforce 5 requires ruby 2.5, so updated that requirement as well. Also updated the tests to point to the latest version of the API at time of writing.