Only set .onboarding-focus class when onboarding is enabled #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*This fix will allow undefined index handling...i.e. when onboardingSteps load
asynchronously and scope index is not yet available.
*Example:
*Say you have a factory, OnboardingFactory, that loads the steps.
$scope.onboardingEnabled = false;
OnboardingFactory.getOnboardingSteps().then(function(steps){
$scope.onboardingSteps = steps;
$scope.onboardingEnabled = true;
$scope.onboardingIndex = 0;
});
*Check index watch newval is undefined instead of === null to allow for this.
*Adjust step count to account for steps deferred initialization
*This fix will allow undefined index handling...i.e. when onboardingSteps load
asynchronously and scope index is not yet available.
*Example:
*Say you have a factory, OnboardingFactory, that loads the steps.
$scope.onboardingEnabled = false;
OnboardingFactory.getOnboardingSteps().then(function(steps){
$scope.onboardingSteps = steps;
$scope.onboardingEnabled = true;
$scope.onboardingIndex = 0;
});
*Check index watch newval is undefined instead of === null to allow for this.
Undefined Scope Index Fix
adjusted package name for NPM
Step info config
Remove duplicate api description Height from readme.md file
Built js Make update cycle also run on 'enabled' change
|
Attached item is not focused in case of
Sorry to ask this here as issues tab is disabled. . . . . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever the onboarding is not (yet) active, the
onboarding-focusclass is set on the element of the first step. This might conflict with some existing z-index attributes, yielding unwanted behavior (as it did in my case).This PR runs the update logic on changes to
indexas well asenabled, and only sets theonboarding-focusclass on elements when the onboarding is active.