Move worker name to static var

adamguo0 · Dec 20, 2023 · c992287 · c992287
1 parent b0940f3
commit c992287
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/src/clientauth.c b/src/clientauth.c
@@ -98,6 +98,7 @@
 
 static const char *clientauth_shmem_name = "pgtle_clientauth";
 static const char *clientauth_feature = "clientauth";
+static const char *clientauth_worker_name = "pg_tle_clientauth worker";
 
 /* Background worker main entry function */
 PGDLLEXPORT void clientauth_launcher_main(Datum arg);
@@ -330,11 +331,11 @@ clientauth_init(void)
 	worker.bgw_notify_pid = 0;
 	sprintf(worker.bgw_library_name, PG_TLE_EXTNAME);
 	sprintf(worker.bgw_function_name, "clientauth_launcher_main");
-	snprintf(worker.bgw_type, BGW_MAXLEN, "pg_tle_clientauth worker");
+	snprintf(worker.bgw_type, BGW_MAXLEN, "%s", clientauth_worker_name);
 
 	for (int i = 0; i < clientauth_num_parallel_workers; i++)
 	{
-		snprintf(worker.bgw_name, BGW_MAXLEN, "pg_tle_clientauth worker %d", i);
+		snprintf(worker.bgw_name, BGW_MAXLEN, "%s worker %d", clientauth_worker_name, i);
 		worker.bgw_main_arg = Int32GetDatum(i);
 		RegisterBackgroundWorker(&worker);
 	}
@@ -348,18 +349,14 @@ clientauth_init(void)
 		RegisteredBgWorker *rw;
 
 		rw = slist_container(RegisteredBgWorker, rw_lnode, siter.cur);
-		if (strncmp(rw->rw_worker.bgw_type, "pg_tle_clientauth worker", BGW_MAXLEN) == 0)
-		{
+		if (strncmp(rw->rw_worker.bgw_type, clientauth_worker_name, BGW_MAXLEN) == 0)
 			num_registered_workers++;
-		}
 	}
 
 	if (num_registered_workers < clientauth_num_parallel_workers)
-	{
 		ereport(ERROR,
 				errmsg("\"%s.clientauth\" feature was not able to create background workers", PG_TLE_NSPNAME),
 				errhint("Consider increasing max_worker_processes or decreasing pgtle.clientauth_num_parallel_workers."));
-	}
 }
 
 void