-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to Qt5.9 #68
base: master
Are you sure you want to change the base?
Support to Qt5.9 #68
Conversation
development merged to master
Getting support to PyQt5
This fails if both PyQt4 and PyQt4 are available bu only > python
Python 2.7.13 (default, Mar 22 2017, 12:31:17) [GCC] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from PyQt5.QtCore import *
>>> from PyQt4.QtCore import *
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
RuntimeError: the PyQt4.QtCore and PyQt5.QtCore modules both wrap the QObject class |
Additionally, QtWebKit is available for PyQt5, too (however, I don't know if it has been marked as deprecated). I would suggest to use find_spec from importlib to validate the dependencies instead of try..except:
(Edit: Sorry, using find_spec would break Python 2.x support) |
Yeah! The Problem is the qt developer changed a lot of things on calling some libraries and methods, for example WebPage was changed to WebPageEngine and it messed up everything. |
The easiest solution would be to move the import of QtWebEngine into the first line and only support QtWebKit for Qt4 and QtWebEngine for Qt5. |
Hi!
I've made some adjustments to support Qt5.9