Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(GH Actions): no install needed to deploy + updated Actions deps #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mountainash
Copy link

As this project has no packages to install, there's no need to run npm install in the Deploy process (and even if there was they aren't used in the deploy process).

I've updated the other 3rd Actions versions and remove some unnecessary envvar settings.

@adamschwartz
Copy link
Owner

This looks good, thanks. I’m a little reluctant to change the version of the wrangler action without a specific reason. How confident are you that this entire change won’t break anything if I merge it? (Would you be willing to make the revert if it did?)

@mountainash
Copy link
Author

mountainash commented Jun 24, 2023

I've tested my deployment and it worked fine (but I used the new Wrangler Action; but I've compared the codebase of 1.2 against 2.0 and the changes seem to be for additional arguments that this project doesn't use).

I'm very confident it won't break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants