Fix #558 #567
Merged
Fix #558 #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Native_Name where possible (639-2 codes)
Basic structure working. Source refactored / minimized from https://ldml.api.sil.org/langtags.json, which means we can pull in updates when needed. Still need to do some build cleanup, and verify that our RFC5646 code is getting built correctly.
Add some helper code to suggest / auto-add the language name. Looks like we're okay with RFC5646 compliance.
Check in minified langtags. Ideally this would be generated by the pre-build from the langtags.js in the scripts directory, but we only need to generate this a couple times a year.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #558 .
Changes proposed in this request:
@adapt-it/developers