Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine table markdown output #752

Merged
merged 2 commits into from
Nov 29, 2024
Merged

refine table markdown output #752

merged 2 commits into from
Nov 29, 2024

Conversation

unsleepy22
Copy link
Contributor

currently extracting markdown from web pages does not return proper markdown for tables.
e.g., for page like https://www.formula1.com/en/latest/article/formula-1-qatar-airways-qatar-grand-prix-2024-timetable.2IVEFdWCCYlUGDNcfJo5pJ, current returned markdown is like:

FRIDAY 29th NOVEMBER | Local time | |
---|---|---|

Porsche Carrera Cup Middle East | Practice Session | 11:50 - 12:35 |

F1 Academy | First Practice Session | 13:00 - 13:40 |

FIA Formula 2 | Practice Session | 14:05 - 14:50 |

we would expect tables formatted like:

| FRIDAY 29th NOVEMBER | Local time | |
|---|---|---|
| Porsche Carrera Cup Middle East | Practice Session | 11:50 - 12:35 |
| F1 Academy | First Practice Session | 13:00 - 13:40 |
| FIA Formula 2 | Practice Session | 14:05 - 14:50 |
| Paddock Club | Paddock Club Track Tour | 15:00 - 15:50 |
...

which is more standard and compact.

@adbar
Copy link
Owner

adbar commented Nov 29, 2024

@unsleepy22 Thanks for the PR, the tests pass now, I'll have a look.

@adbar adbar merged commit 117ba8b into adbar:master Nov 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants