Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ember): officially support ember v5 #1208

Merged
merged 1 commit into from
Mar 18, 2024
Merged

feat(ember): officially support ember v5 #1208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ jobs:
- ember-lts-4.4
- ember-lts-4.8
- ember-lts-4.12
- ember-lts-5.4
- ember-release
- ember-beta
- ember-canary
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@
"edition": "octane"
},
"peerDependencies": {
"ember-source": "^4.0.0"
"ember-source": ">= 4.0.0"
},
"ember-addon": {
"configPath": "tests/dummy/config",
Expand Down
24 changes: 7 additions & 17 deletions tests/dummy/config/ember-try.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ module.exports = async function () {
"ember-source": "~4.4.0",
},
},
env: {
EMBROIDER_TEST_SETUP_FORCE: "classic",
},
},
{
name: "ember-lts-4.8",
Expand All @@ -25,9 +22,6 @@ module.exports = async function () {
"ember-source": "~4.8.0",
},
},
env: {
EMBROIDER_TEST_SETUP_FORCE: "classic",
},
},
{
name: "ember-lts-4.12",
Expand All @@ -36,8 +30,13 @@ module.exports = async function () {
"ember-source": "~4.12.0",
},
},
env: {
EMBROIDER_TEST_SETUP_FORCE: "classic",
},
{
name: "ember-lts-5.4",
npm: {
devDependencies: {
"ember-source": "~5.4.0",
},
},
},
{
Expand All @@ -47,9 +46,6 @@ module.exports = async function () {
"ember-source": await getChannelURL("release"),
},
},
env: {
EMBROIDER_TEST_SETUP_FORCE: "classic",
},
},
{
name: "ember-beta",
Expand All @@ -58,9 +54,6 @@ module.exports = async function () {
"ember-source": await getChannelURL("beta"),
},
},
env: {
EMBROIDER_TEST_SETUP_FORCE: "classic",
},
},
{
name: "ember-canary",
Expand All @@ -69,9 +62,6 @@ module.exports = async function () {
"ember-source": await getChannelURL("canary"),
},
},
env: {
EMBROIDER_TEST_SETUP_FORCE: "classic",
},
},
embroiderSafe(),
embroiderOptimized(),
Expand Down
Loading