Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(customer-center): build args were not passed to docker build #1350

Merged
merged 1 commit into from
Dec 11, 2024
Merged

fix(customer-center): build args were not passed to docker build #1350

merged 1 commit into from
Dec 11, 2024

Conversation

c0rydoras
Copy link
Contributor

@c0rydoras c0rydoras commented Dec 11, 2024 •
edited
Loading

this caused it to use http://localhost:8000 for the API

Description

  • update to fixed version of customer-center image

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@c0rydoras
fix(customer-center): build args were not passed to docker build
3090bd4 
this caused it to use http://localhost:8000 for the API
@c0rydoras c0rydoras requested review from a team as code owners December 11, 2024 13:54
@c0rydoras c0rydoras requested review from eyenx and tongpu December 11, 2024 13:54
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 11, 2024
@c0rydoras c0rydoras enabled auto-merge (rebase) December 11, 2024 13:57
@c0rydoras c0rydoras merged commit d8d1b17 into adfinis:main Dec 11, 2024
3 checks passed
@c0rydoras c0rydoras deleted the chore/customer/center-bump-again branch December 11, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derrabauke derrabauke derrabauke approved these changes

@eyenx eyenx Awaiting requested review from eyenx eyenx is a code owner automatically assigned from adfinis/helm-charts

@tongpu tongpu Awaiting requested review from tongpu tongpu is a code owner automatically assigned from adfinis/helm-charts

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c0rydoras @derrabauke