Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(security-apps): Add dex-k8s-authenticator #445

Merged
merged 3 commits into from
Dec 1, 2021

Conversation

isantospardo
Copy link
Contributor

@isantospardo isantospardo commented Nov 29, 2021

Description

Due to gangway deprecation
FFI: https://github.com/heptiolabs/gangway#vmware-has-ended-active-development-of-this-project-this-repository-will-no-longer-be-updated

Issues

Gangway deprecation

Checklist

  • I updated the version in Chart.yaml
  • I updated applicable README.md files using pre-commit run -a
  • I documented any high-level concepts I'm introducing in docs/
  • If I updated a dependency tool, or app, this PR contains a short summary of the changes I'm pulling
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 29, 2021
@isantospardo isantospardo force-pushed the feature/add-dexk8sauthenticator branch 6 times, most recently from f955f2b to c46e1e1 Compare November 29, 2021 13:58
@isantospardo isantospardo force-pushed the feature/add-dexk8sauthenticator branch from 29ad1d9 to 8f9a557 Compare November 29, 2021 14:45
@isantospardo isantospardo force-pushed the feature/add-dexk8sauthenticator branch from 8f9a557 to 161b9f4 Compare November 30, 2021 12:48
@isantospardo isantospardo force-pushed the feature/add-dexk8sauthenticator branch from 161b9f4 to 32f70d1 Compare November 30, 2021 12:55
@isantospardo isantospardo marked this pull request as ready for review November 30, 2021 12:56
@isantospardo isantospardo requested a review from a team as a code owner November 30, 2021 12:56
@isantospardo isantospardo requested review from vmaillot and removed request for a team November 30, 2021 12:56
@isantospardo isantospardo force-pushed the feature/add-dexk8sauthenticator branch 2 times, most recently from 6dfde75 to 32f70d1 Compare November 30, 2021 13:07
@isantospardo isantospardo requested a review from eyenx November 30, 2021 13:08
Copy link
Contributor

@hairmare hairmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please switch to the charts official helm repo as per my comments above

@hairmare hairmare dismissed their stale review December 1, 2021 07:23

just noticed that the repo i recommended was never finished

@isantospardo
Copy link
Contributor Author

@hairmare thanks for checking, yeah, I don't see any indexes there, so should I proceed directly pointing to the version, right?

@hairmare
Copy link
Contributor

hairmare commented Dec 1, 2021

@hairmare thanks for checking, yeah, I don't see any indexes there, so should I proceed directly pointing to the version, right?

yes, but add a comment to the code that explains the situation in detail and include a bunch of links to upstreams discussions regarding helm charts

if you could also check if upstream if there are any recent updates for upstreams helm charting efforts that would be awesome

@isantospardo isantospardo force-pushed the feature/add-dexk8sauthenticator branch from 6a3af69 to 2c08bc6 Compare December 1, 2021 09:29
@isantospardo isantospardo requested a review from hairmare December 1, 2021 10:20
@isantospardo isantospardo merged commit 1d709aa into master Dec 1, 2021
@isantospardo isantospardo deleted the feature/add-dexk8sauthenticator branch December 1, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants