fix: set status for canceled cases #1202
Conversation
open-dynaMIX
force-pushed
the
set_status_cancelled
branch
from
f80e2cb to
cadf6fd
Compare
| case=None, | ||
| **kwargs, | ||
| ): | ||
| def set_case_status(case=None, work_item=None): |
There was a problem hiding this comment.
This function has so little common code, I'd just split it in two and get rid of the whole if workitem else stuff
There was a problem hiding this comment.
This messes up my precious coverage 😖
open-dynaMIX
force-pushed
the
set_status_cancelled
branch
from
cadf6fd to
38ab62d
Compare
open-dynaMIX
force-pushed
the
set_status_cancelled
branch
3 times, most recently
from
ffd4878 to
9c1fec8
Compare
|
@winged Had to refactor it a little more. But now it's also more better ;) Additionally I saw, Caluma uses the spelling |
open-dynaMIX
force-pushed
the
set_status_cancelled
branch
from
9c1fec8 to
b20ebe2
Compare
Nice! BTW why are we using a meta field here instead of referring to the case's own status field? |
| work_item = ( | ||
| work_item if work_item else case.work_items.filter(status="ready").first() | ||
| ) | ||
| work_item = case.work_items.filter(status="ready").first() |
There was a problem hiding this comment.
I'd probably try to use a constant here
| work_item = case.work_items.filter(status="ready").first() | |
| work_item = case.work_items.filter(status=WorkItem.STATUS_READY).first() |
There was a problem hiding this comment.
I'm all here for the nitpicks ;)
You are correct and it's fixed 👍
Cancelled cases are still accessible via their URL. So the status needs to be set correctly. This commit adds a new status `canceled` and sets it on cancelation of a case. Additionally the event handlers were refactored in the following way: - only cases with the `document-review` Workflow get a status applied. - The status is set on every change of ready WorkItems, not only on the expected forward changes. This makes sure, that the status is also correct, if a Case was closed and then reopened.
open-dynaMIX
force-pushed
the
set_status_cancelled
branch
from
b20ebe2 to
457b06b
Compare
open-dynaMIX
changed the title
Cancelled cases are still accessible via their URL. So the status needs
to be set correctly. This commit adds a new status
canceledandsets it on cancelation of a case.
Additionally the event handlers were refactored in the following way:
document-reviewWorkflow get a status applied.expected forward changes. This makes sure, that the status is also
correct, if a Case was closed and then reopened.
drive-by commit