Add display/enable conditions to buttons in AddWordDialogFragment #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are cases where some of
AddWordDialogFragment
's buttons are not expected - for example, the Move up button when adding a new key. To combat this, this pull request introduces conditions for some of these buttons - the following conditions have been added:index > -1
(when editing existing key), disabled ifindex == 0
(when the topmost key is chosen)keyCount <= 1
(to avoid making the list empty)As a bonus, dialog title has also been changed to "Add Key" when adding a key.
Screenshots
Additional notes
onStart
, as thegetButton
method returns null if the dialog is not fully created.