Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Avoid commands to be executed while components are shutting down #158

Conversation

krakatoa
Copy link

This blocks commands to be sent on calls which received the hangup event. The fix lacks of specs. I've tested manually and seems correct.

@benlangfeld
Copy link
Member

The Asterisk version of this has specs. Could you please reproduce those for this, please?

@krakatoa
Copy link
Author

Sorry for the delay.

@benlangfeld
Copy link
Member

Cool, I'll merge this once the build is confirmed green :)

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0082078 on krakatoa:157_avoid_commands_on_finished_components into * on adhearsion:develop*.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0082078 on krakatoa:157_avoid_commands_on_finished_components into * on adhearsion:develop*.

@benlangfeld
Copy link
Member

Oops, it turns out one of these specs fails. Could you take a look at correcting that?

@krakatoa
Copy link
Author

Sure Ben. I made it pass on an old branch, I'm updating it and making it pass again.

@emcgee
Copy link

emcgee commented Sep 19, 2013

@krakatoa Did you ever get around to fix up this spec? Running into this little issue quite frequently and I'll fix it up if you haven't.

@benlangfeld
Copy link
Member

I'm going to close this since it never met the merge requirements and has been thoroughly superseded by mod_rayo :) See #201

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants