Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-admin/rex: Initial ebuild with adjust patches #534

Merged
merged 4 commits into from
Jun 3, 2021

Conversation

alip
Copy link
Contributor

@alip alip commented Feb 18, 2021

Package-Manager: Portage-3.0.8, Repoman-2.3.11

This is rex-1.13.2 plus the adjust patches which have been included in trex-1.6.0.4 except RexOps/Rex#1471 which has been in trex master. I have carefully reviewed the changeset between current trex and latest rex and filtered out the patches which have already been fixed upstream. I have been testing this without issues for a couple of days now and there're no critical changes between the two versions so I'm relatively confident this won't kill your kittens. Still, you've been warned. Submitting this pull request with the hope to get wider testing. Note you have to uninstall trex before installing rex as they're blocking each other obviously due to file collisions.

The ebuild is identical to the one in gentoo-x86 except for the change below:

PATCHES=(
"${FILESDIR}"/adjust_patches/0001-LibVirt-Initial-support-for-virtio-scsi-virtual-driv.patch
"${FILESDIR}"/adjust_patches/0002-t-issue-948.t-Fixing-whitespace-detection-in-test.patch
"${FILESDIR}"/adjust_patches/0003-Shell.pm-add-iDRAC-4.00.00.00-support.patch
"${FILESDIR}"/adjust_patches/0004-Shell.pm-add-iLO-support.patch
"${FILESDIR}"/adjust_patches/0005-Allow-uploading-files-even-when-permissions-cannot-b.patch
"${FILESDIR}"/adjust_patches/0006-Only-apply-best-effort-option-if-sudo-is-not-availab.patch
)

All patches listed above have already been submitted upstream.
Current process of unforking can be tracked here: adjust/Rex#28.
This pull request obsoletes #474.

@xmhd
Copy link
Contributor

xmhd commented Feb 18, 2021

LGTM. I will test it out locally today.

@alip alip added in progress and removed review labels Mar 9, 2021
@alip
Copy link
Contributor Author

alip commented Mar 9, 2021

After discussing with upstream we decided submitting two of the patches as modules to CPAN is a better idea.
I'll adapt this PR accordingly hence s/review/in progress/ for the time being.

Package-Manager: Portage-3.0.8, Repoman-2.3.11
@alip alip force-pushed the rex-1-13-2-with-adjust-patches branch from e0e0e9c to 49b3d80 Compare March 9, 2021 14:43
alip added 3 commits March 9, 2021 15:47
Package-Manager: Portage-3.0.8, Repoman-2.3.11
Package-Manager: Portage-3.0.8, Repoman-2.3.11
Package-Manager: Portage-3.0.8, Repoman-2.3.11
@alip
Copy link
Contributor Author

alip commented Mar 9, 2021

Updated adjust patches and added initial ebuilds for Rex-Interface-Shell-I{drac4,lo}.

@alip alip added review and removed in progress labels Mar 9, 2021
@alip
Copy link
Contributor Author

alip commented Mar 9, 2021

Note: add Rex-Interface-Shell-I{drac4,lo} to adjust-infrastructure meta package once #542 is merged.

@xmhd
Copy link
Contributor

xmhd commented Jun 3, 2021

have been using this for a bit, and seems to be working fine.

I am merging this PR and will update the infrastructure package with || ( app-admin/rex app-admin/trex ) and we can keep trex around for bit before we decide to remove.

@xmhd xmhd merged commit 1e1c6fa into master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants