Sourcery refactored master branch #2

sourcery-ai · 2020-08-09T14:44:37Z

Branch master refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the master branch, then run:

git fetch origin sourcery/master
git merge --ff-only FETCH_HEAD
git reset HEAD^

scribe-connect · 2020-08-09T14:44:40Z

Linked documents: 0
Files with no linked documents: 13
Recently updated documents: 0
Out of date documents: 0
Very out of date documents: 0

sourcery-ai · 2020-08-09T14:44:38Z

gui_cvs/hello.py

-        lbl = gui.Label("Hello world!", width=100, height=30)
-
        # return of the root widget
-        return lbl
+        return gui.Label("Hello world!", width=100, height=30)


Function MyApp.main refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2020-08-09T14:44:38Z

gui_cvs/table.py

-        for ri in range(0, table.row_count()):
-            for ci in range(0, table.column_count()):
+        for ri in range(table.row_count()):
+            for ci in range(table.column_count()):


Function MyApp.fill_table refactored with the following changes:

Replace range(0, x) with range(x) (remove-zero-from-range)

sourcery-ai · 2020-08-09T14:44:38Z

gui_wizard/helloworld.py

-        if not 'editing_mode' in kwargs.keys():
+        if 'editing_mode' not in kwargs.keys():


Function untitled.__init__ refactored with the following changes:

Simplify logical expression using De Morgan identities (de-morgan)

sourcery-ai · 2020-08-09T14:44:38Z

gui_wizard/helloworld.py

@@ -43,7 +43,6 @@ def construct_ui(self):

    def onclick_button(self, emitter):
        self.mainContainer.children['label'].set_text('hello world')
-        pass


Function untitled.onclick_button refactored with the following changes:

Remove redundant pass statement (remove-redundant-pass)

sourcery-ai · 2020-08-09T14:44:39Z

src/cvs/webcam.py

-        if not 'editing_mode' in kwargs.keys():
+        if 'editing_mode' not in kwargs.keys():


Function untitled.__init__ refactored with the following changes:

Simplify logical expression using De Morgan identities (de-morgan)

sourcery-ai · 2020-08-09T14:44:40Z

src/mutilpose/posenet/model.py

-    model_cfg = {
+    return {
        'output_stride': output_stride,
        'checkpoint_name': checkpoint_name,
    }
-    return model_cfg


Function load_config refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2020-08-09T14:44:41Z

src/mutilpose/posenet/utils.py

-    out_img = cv2.drawKeypoints(img, cv_keypoints, outImage=np.array([]))
-    return out_img
+    return cv2.drawKeypoints(img, cv_keypoints, outImage=np.array([]))


Function draw_keypoints refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2020-08-09T14:44:41Z

src/mutilpose/posenet/converter/config.py

-    cfg = yaml.load(cfg_f)
-    return cfg
+    return yaml.load(cfg_f)


Function load_config refactored with the following changes:

Inline variable that is immediately returned (inline-immediately-returned-variable)

sourcery-ai · 2020-08-09T14:44:41Z

src/singlepose/webpose.py

-            
+


Function main refactored with the following changes:

Replace assignment with augmented assignment (aug-assign)

Replace range(0, x) with range(x) (remove-zero-from-range)

sourcery-ai · 2020-08-09T14:44:41Z

src/singlepose/webpose.py

-        self.lbl.set_text(cvs.getLbs())
-        pass    
+        self.lbl.set_text(cvs.getLbs())    


Function MyApp.idle refactored with the following changes:

Remove redundant pass statement (remove-redundant-pass)

pep8speaks · 2020-08-09T14:44:45Z

Hello @sourcery-ai[bot]! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file src/singlepose/webpose.py:

Line 54:17: E303 too many blank lines (2)
Line 137:40: W291 trailing whitespace

Comment last updated at 2020-08-09 14:45:33 UTC

pull-assistant · 2020-08-09T14:44:45Z

Best reviewed: commit by commit

Optimal code review plan

'Refactored by Sourcery'

Powered by Pull Assistant. Last update 9b5af2f ... 9b5af2f. Read the comment docs.

commit-lint · 2020-08-09T14:45:30Z

generate by www.commit-lint.com

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

@Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
@Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
@Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
@Commit-Lint merge disable will desactivate merge dependabot PR
@Commit-Lint review will approve dependabot PR
@Commit-Lint stop review will stop approve dependabot PR

sourcery-ai · 2020-08-09T14:45:39Z

Sourcery Code Quality Report (beta)

✅ Merging this PR will increase code quality in the affected files by 0.01 out of 10.

Quality metrics	Before	After	Change
Complexity	1.79	1.74	-0.05 🔵
Method Length	55.68	55.32	-0.36 🔵
Quality	8.71	8.72	0.01 🔵

Other metrics	Before	After	Change
Lines	997	985	-12

Changed files	Quality Before	Quality After	Quality Change
gui_cvs/hello.py	9.73	9.75	0.02 🔵
gui_cvs/table.py	9.17	9.17	0.00
gui_wizard/helloworld.py	9.19	9.20	0.01 🔵
src/cvs/webcam.py	9.47	9.48	0.01 🔵
src/facencnn/facepose.py	8.58	8.59	0.01 🔵
src/handtf/webcam.py	8.60	8.60	0.00
src/handtf/utils/detector_utils.py	8.07	8.08	0.01 🔵
src/mutilpose/webcam_demo.py	8.58	8.58	0.00
src/mutilpose/posenet/decode_multi.py	7.95	7.99	0.04 🔵
src/mutilpose/posenet/model.py	8.46	8.48	0.02 🔵
src/mutilpose/posenet/utils.py	8.30	8.30	0.00
src/mutilpose/posenet/converter/config.py	9.55	9.59	0.04 🔵
src/singlepose/webpose.py	8.52	8.52	0.00

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Overall	Recommendation
src/singlepose/webpose.py	main	17	612.50	3.38	Split out functionality
src/facencnn/facepose.py	main	13	260.53	4.42	Split out functionality
src/handtf/utils/detector_utils.py	draw_box_on_image	12	252.58	4.56	Split out functionality
src/mutilpose/posenet/decode_multi.py	decode_multiple_poses	8	232.73	5.10	Split out functionality
src/handtf/webcam.py	main	10	189.74	5.32	Split out functionality

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

sourcery-ai bot commented Aug 9, 2020

View reviewed changes

pull-request-size bot added the size/M label Aug 9, 2020

restyled-io bot mentioned this pull request Aug 9, 2020

Restyle Sourcery refactored master branch #3

Open

trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Aug 9, 2020

'Refactored by Sourcery'

9b5af2f

sourcery-ai bot force-pushed the sourcery/master branch from 24ee78a to 9b5af2f Compare August 9, 2020 14:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sourcery refactored master branch #2

Sourcery refactored master branch #2

sourcery-ai bot commented Aug 9, 2020

scribe-connect bot commented Aug 9, 2020

sourcery-ai bot Aug 9, 2020

sourcery-ai bot Aug 9, 2020

sourcery-ai bot Aug 9, 2020

sourcery-ai bot Aug 9, 2020

sourcery-ai bot Aug 9, 2020

sourcery-ai bot Aug 9, 2020

sourcery-ai bot Aug 9, 2020

sourcery-ai bot Aug 9, 2020

sourcery-ai bot Aug 9, 2020

sourcery-ai bot Aug 9, 2020

pep8speaks commented Aug 9, 2020 •

edited

Loading

pull-assistant bot commented Aug 9, 2020 •

edited

Loading

commit-lint bot commented Aug 9, 2020

sourcery-ai bot commented Aug 9, 2020

		if not 'editing_mode' in kwargs.keys():
		if 'editing_mode' not in kwargs.keys():

Sourcery refactored master branch #2

Are you sure you want to change the base?

Sourcery refactored master branch #2

Conversation

sourcery-ai bot commented Aug 9, 2020

scribe-connect bot commented Aug 9, 2020

sourcery-ai bot Aug 9, 2020

Choose a reason for hiding this comment

sourcery-ai bot Aug 9, 2020

Choose a reason for hiding this comment

sourcery-ai bot Aug 9, 2020

Choose a reason for hiding this comment

sourcery-ai bot Aug 9, 2020

Choose a reason for hiding this comment

sourcery-ai bot Aug 9, 2020

Choose a reason for hiding this comment

sourcery-ai bot Aug 9, 2020

Choose a reason for hiding this comment

sourcery-ai bot Aug 9, 2020

Choose a reason for hiding this comment

sourcery-ai bot Aug 9, 2020

Choose a reason for hiding this comment

sourcery-ai bot Aug 9, 2020

Choose a reason for hiding this comment

sourcery-ai bot Aug 9, 2020

Choose a reason for hiding this comment

pep8speaks commented Aug 9, 2020 • edited Loading

Comment last updated at 2020-08-09 14:45:33 UTC

pull-assistant bot commented Aug 9, 2020 • edited Loading

commit-lint bot commented Aug 9, 2020

generate by www.commit-lint.com

sourcery-ai bot commented Aug 9, 2020

Sourcery Code Quality Report (beta)

pep8speaks commented Aug 9, 2020 •

edited

Loading

pull-assistant bot commented Aug 9, 2020 •

edited

Loading