Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable custom CSR signer name #211

Merged
merged 7 commits into from
Sep 8, 2024

Conversation

rdvencioneck
Copy link
Contributor

@rdvencioneck rdvencioneck commented Jun 24, 2024

Some Control planes, such as AWS EKS, won't accept kubernetes.io/kubelet-serving as the CSR SignerName.
As documented here, EKS users can use beta.eks.amazonaws.com/app-serving as the SignerName, instead, to get the certificate properly signed by the control plane.

This PR will enable any custom SignerName, so that it can work for EKS or other managed control planes that may require custom SignerName. Solves #120

@adrienjt
Copy link
Contributor

adrienjt commented Jul 19, 2024

Thank you @rdvencioneck and sorry for the late reply. Could you please add the field to the chart's readme.

And ideally a note or page in the operator guide. I'm sure a lot of people will find this useful.

Out of scope for this PR: a subsequent PR would be welcome to run the end-to-end tests on EKS, to prove that this works and continues to work. Basically, this old PR could be revived: https://github.com/admiraltyio/admiralty/pull/122/files

@rdvencioneck
Copy link
Contributor Author

hi @adrienjt
sorry, I missed your review.
I've included the requested info and will take a look at the referenced PR after this one is merged

Thanks!

charts/multicluster-scheduler/README.md Outdated Show resolved Hide resolved
docs/operator_guide/authentication.md Outdated Show resolved Hide resolved
docs/operator_guide/authentication.md Outdated Show resolved Hide resolved
cmd/agent/main.go Outdated Show resolved Hide resolved
@rdvencioneck rdvencioneck requested a review from adrienjt August 25, 2024 21:37
@adrienjt adrienjt enabled auto-merge (squash) August 31, 2024 18:21
@rdvencioneck
Copy link
Contributor Author

@adrienjt could you please trigger the tests again?
They passed previously, but auto-merge didn't work for some reason

@adrienjt adrienjt enabled auto-merge (squash) September 4, 2024 23:28
@adrienjt adrienjt merged commit 6882784 into admiraltyio:master Sep 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants