-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable custom CSR signer name #211
Conversation
Thank you @rdvencioneck and sorry for the late reply. Could you please add the field to the chart's readme. And ideally a note or page in the operator guide. I'm sure a lot of people will find this useful. Out of scope for this PR: a subsequent PR would be welcome to run the end-to-end tests on EKS, to prove that this works and continues to work. Basically, this old PR could be revived: https://github.com/admiraltyio/admiralty/pull/122/files |
hi @adrienjt Thanks! |
@adrienjt could you please trigger the tests again? |
Some Control planes, such as AWS EKS, won't accept
kubernetes.io/kubelet-serving
as the CSR SignerName.As documented here, EKS users can use
beta.eks.amazonaws.com/app-serving
as the SignerName, instead, to get the certificate properly signed by the control plane.This PR will enable any custom SignerName, so that it can work for EKS or other managed control planes that may require custom SignerName. Solves #120