Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump k8s dependencies to v1.30 and VK to v1.11.0 #226

Merged
merged 6 commits into from
Oct 5, 2024

Conversation

marwanad
Copy link
Contributor

This PR bumps k8s dependencies to 1.30 and updates the test matrix.

It also updates the VK version to fix an issue with port-forwarding due to unsupported SPDY protocols.

@marwanad
Copy link
Contributor Author

Note: Later controller runtime version doesn't play with VK because of some changed method signatures - I'm gonna address this in a follow-up.

Copy link
Contributor

@adrienjt adrienjt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you so much!

test/e2e/kind.sh Outdated Show resolved Hide resolved
test/e2e/kind.sh Show resolved Hide resolved
@adrienjt
Copy link
Contributor

adrienjt commented Oct 5, 2024

Have you tried to e2e test with 1.31, even if you can't build against it?

Currently, we're building against 1.27, but testing up to 1.28.

@marwanad
Copy link
Contributor Author

marwanad commented Oct 5, 2024

@adrienjt e2e works, I updated this change to support 1.31 in the test matrix.

@adrienjt adrienjt merged commit fa8a3a4 into admiraltyio:master Oct 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants