COMPLETE THE LEVEL 500 #1
Conversation
adniyaYousaf
commented
Feb 7, 2024
•
adniyaYousaf
commented
- I have committed my files one by one, on purpose, and for a reason
- I have titled my PR with COHORT_NAME | FIRST_NAME LAST_NAME | REPO_NAME | WEEK
- I have tested my changes
- My changes follow the style guide
- My changes meet the requirements of this task
This comment was marked as duplicate.
This comment was marked as duplicate.
✅ Deploy Preview for adniyayoussaf-tvshow ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| }) | ||
| } | ||
| // fetch Api function to fetch the Episodes of selected show | ||
| async function getAllEpisodes() { |
There was a problem hiding this comment.
It is generally considered to be good practice to provide the external data needed by the function as an argument. For example, it would be better to pass selectedShow as an argument rather than relying directly on the global variable. The global variable can be modified elsewhere in the code while the function is still in the middle of running and can lead to unexpected behaviour in certain cases.
There was a problem hiding this comment.
I tried to pass selectedShow as argument but somehow it was't working. I will look into it again. Thank you.
| clearShows(); | ||
| const episodeName = selectedOption.textContent.split('-') | ||
| SearchTerm = episodeName[1]; | ||
| makePageCards(); |
There was a problem hiding this comment.
Could you please elaborate how would the function makePageCards act in the scope of this current function?
There was a problem hiding this comment.
When I select a episode from the episode dropdown I only see a black screen, is that the intended outcome or is it a bug?
There was a problem hiding this comment.
makePageCards create filtered cards for Episodes acoording to SearchTerm. This function is Updating the SearchTerm and calling the makePageCards function to create filtered cards.
Yes, there is bug in Episodes dropDown. I will try to fix it. Thank you
✅ Deploy Preview for relaxed-bunny-77ee37 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
