Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Target rules engine for ODD #28

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

artur-ciocanu
Copy link
Collaborator

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@artur-ciocanu artur-ciocanu changed the base branch from move-spec-to-tests to main December 5, 2024 17:54
@coveralls
Copy link

coveralls commented Dec 5, 2024

Pull Request Test Coverage Report for Build 12198404856

Details

  • 127 of 141 (90.07%) changed or added relevant lines in 17 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.8%) to 90.613%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils/hashing.ts 26 31 83.87%
src/executors/target/target-rules-executor.ts 20 29 68.97%
Totals Coverage Status
Change from base Build 12185301280: -0.8%
Covered Lines: 317
Relevant Lines: 342

💛 - Coveralls

@artur-ciocanu artur-ciocanu changed the title Adding rule key and rule set metadata Adding Target rules engine for ODD Dec 6, 2024
throw new Error("ECID identities array is empty or not an array");
}

const result = identities[0].id;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could be missions on other entries? Should we check all records?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants