remove message-feed (#1065)

adobe · Oct 25, 2023 · b5a39e0 · b5a39e0
1 parent 121c8c2
commit b5a39e0
Show file tree

Hide file tree

Showing 12 changed files with 12 additions and 1,191 deletions.
diff --git a/sandbox/src/App.js b/sandbox/src/App.js
@@ -32,7 +32,6 @@ import Identity from "./Identity";
 import AlloyVersion from "./components/AlloyVersion";
 import ConfigOverrides from "./ConfigOverrides.jsx";
 import InAppMessages from "./components/InAppMessagesDemo/InAppMessages";
-import MessageFeed from "./components/MessageFeedDemo/MessageFeed";
 
 const BasicExample = () => {
   return (
@@ -101,9 +100,6 @@ const BasicExample = () => {
             <li>
               <Link to="/inAppMessages">In-app Messages</Link>
             </li>
-            <li>
-              <Link to="/messageFeed">Message Feed</Link>
-            </li>
           </ul>
           <hr />
 
@@ -134,7 +130,6 @@ const BasicExample = () => {
           <Route path="/identity" component={Identity} />
           <Route path="/configOverrides" component={ConfigOverrides} />
           <Route path="/inAppMessages" component={InAppMessages} />
-          <Route path="/messageFeed" component={MessageFeed} />
         </div>
       </Router>
       <AlloyVersion />

diff --git a/sandbox/src/components/MessageFeedDemo/MessageFeed.css b/sandbox/src/components/MessageFeedDemo/MessageFeed.css
diff --git a/sandbox/src/components/MessageFeedDemo/MessageFeed.js b/sandbox/src/components/MessageFeedDemo/MessageFeed.js
diff --git a/src/components/Personalization/createComponent.js b/src/components/Personalization/createComponent.js
@@ -13,8 +13,8 @@ governing permissions and limitations under the License.
 import { noop, flatMap, isNonEmptyArray } from "../../utils";
 import createPersonalizationDetails from "./createPersonalizationDetails";
 import { AUTHORING_ENABLED } from "./constants/loggerMessage";
-import validateApplyPropositionsOptions from "./validateApplyPropositionsOptions";
 import { PropositionEventType } from "../../constants/propositionEventType";
+import validateApplyPropositionsOptions from "./validateApplyPropositionsOptions";
 
 export default ({
   getPageLocation,
@@ -30,8 +30,7 @@ export default ({
   setTargetMigration,
   mergeDecisionsMeta,
   renderedPropositions,
-  onDecisionHandler,
-  subscribeMessageFeed
+  onDecisionHandler
 }) => {
   return {
     lifecycle: {
@@ -122,8 +121,7 @@ export default ({
         optionsValidator: options =>
           validateApplyPropositionsOptions({ logger, options }),
         run: applyPropositions
-      },
-      subscribeMessageFeed: subscribeMessageFeed.command
+      }
     }
   };
 };
diff --git a/src/components/Personalization/createOnDecisionHandler.js b/src/components/Personalization/createOnDecisionHandler.js
@@ -10,15 +10,8 @@ OF ANY KIND, either express or implied. See the License for the specific languag
 governing permissions and limitations under the License.
 */
 
-export default ({
-  processPropositions,
-  createProposition,
-  collect,
-  subscribeMessageFeed
-}) => {
+export default ({ processPropositions, createProposition, collect }) => {
   return ({ viewName, renderDecisions, propositions }) => {
-    subscribeMessageFeed.refresh(propositions);
-
     if (!renderDecisions) {
       return Promise.resolve();
     }

diff --git a/src/components/Personalization/createSubscribeMessageFeed.js b/src/components/Personalization/createSubscribeMessageFeed.js
diff --git a/src/components/Personalization/index.js b/src/components/Personalization/index.js
@@ -10,7 +10,7 @@ OF ANY KIND, either express or implied. See the License for the specific languag
 governing permissions and limitations under the License.
 */
 
-import { string, boolean, objectOf } from "../../utils/validation";
+import { boolean, objectOf, string } from "../../utils/validation";
 import createComponent from "./createComponent";
 import { initDomActionsModules } from "./dom-actions";
 import createCollect from "./createCollect";
@@ -38,7 +38,6 @@ import createProcessDomAction from "./handlers/createProcessDomAction";
 import createProcessHtmlContent from "./handlers/createProcessHtmlContent";
 import createProcessRedirect from "./handlers/createProcessRedirect";
 import createProcessPropositions from "./handlers/createProcessPropositions";
-import createSubscribeMessageFeed from "./createSubscribeMessageFeed";
 import createOnDecisionHandler from "./createOnDecisionHandler";
 import createProcessInAppMessage from "./handlers/createProcessInAppMessage";
 import initInAppMessageActionsModules from "./in-app-message-actions/initInAppMessageActionsModules";
@@ -122,15 +121,10 @@ const createPersonalization = ({ config, logger, eventManager }) => {
     targetMigrationEnabled
   });
 
-  const subscribeMessageFeed = createSubscribeMessageFeed({
-    collect
-  });
-
   const onDecisionHandler = createOnDecisionHandler({
     processPropositions,
     createProposition,
-    collect,
-    subscribeMessageFeed
+    collect
   });
 
   return createComponent({
@@ -147,8 +141,7 @@ const createPersonalization = ({ config, logger, eventManager }) => {
     setTargetMigration,
     mergeDecisionsMeta,
     renderedPropositions,
-    onDecisionHandler,
-    subscribeMessageFeed
+    onDecisionHandler
   });
 };
 

diff --git a/test/functional/helpers/createAlloyProxy.js b/test/functional/helpers/createAlloyProxy.js
@@ -92,7 +92,6 @@ const commands = [
   "appendIdentityToUrl",
   "applyPropositions",
   "subscribeRulesetItems",
-  "subscribeMessageFeed",
   "evaluateRulesets"
 ];
 

diff --git a/test/unit/specs/components/Personalization/createComponent.spec.js b/test/unit/specs/components/Personalization/createComponent.spec.js
@@ -26,7 +26,6 @@ describe("Personalization", () => {
   let setTargetMigration;
   let mergeDecisionsMeta;
   let renderedPropositions;
-  let subscribeMessageFeed;
   let cacheUpdate;
 
   const build = () => {
@@ -41,8 +40,7 @@ describe("Personalization", () => {
       showContainers,
       setTargetMigration,
       mergeDecisionsMeta,
-      renderedPropositions,
-      subscribeMessageFeed
+      renderedPropositions
     });
   };
 
@@ -72,7 +70,6 @@ describe("Personalization", () => {
     renderedPropositions = jasmine.createSpyObj("renderedPropositions", [
       "clear"
     ]);
-    subscribeMessageFeed = jasmine.createSpy("subscribeMessageFeed");
 
     build();
   });

diff --git a/test/unit/specs/components/Personalization/createOnDecisionHandler.spec.js b/test/unit/specs/components/Personalization/createOnDecisionHandler.spec.js
@@ -183,7 +183,6 @@ describe("Personalization::createOnDecisionHandler", () => {
   let collect;
   let processPropositions;
   let createProposition;
-  let subscribeMessageFeed;
   let onDecisionHandler;
 
   beforeEach(() => {
@@ -200,16 +199,11 @@ describe("Personalization::createOnDecisionHandler", () => {
       isPageWideSurface: () => false
     });
 
-    subscribeMessageFeed = jasmine.createSpyObj("subscribeMessageFeed", [
-      "refresh"
-    ]);
-
     onDecisionHandler = createOnDecisionHandler({
       processPropositions,
       createProposition,
       render,
-      collect,
-      subscribeMessageFeed
+      collect
     });
   });
 
@@ -220,7 +214,6 @@ describe("Personalization::createOnDecisionHandler", () => {
       propositions: PROPOSITIONS
     });
 
-    expect(subscribeMessageFeed.refresh).toHaveBeenCalledOnceWith(PROPOSITIONS);
     expect(render).not.toHaveBeenCalled();
   });
 
@@ -232,7 +225,6 @@ describe("Personalization::createOnDecisionHandler", () => {
     });
 
     expect(propositions).toEqual(PROPOSITIONS);
-    expect(subscribeMessageFeed.refresh).toHaveBeenCalledOnceWith(PROPOSITIONS);
 
     expect(render).toHaveBeenCalledTimes(1);