-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for rendering in-app messages from Adobe Journey Optimizer #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n executeAction method
# Conflicts: # src/core/createEventManager.js # test/functional/specs/Visitor/C35448.js
# Conflicts: # src/core/createEventManager.js
# Conflicts: # src/components/DecisioningEngine/index.js # src/components/DecisioningEngine/utils.js # src/utils/debounce.js # test/unit/specs/components/DecisioningEngine/createContextProvider.spec.js # test/unit/specs/components/DecisioningEngine/utils.spec.js
ninaceban
requested changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
createIframe
can reuse utils/dom
helpers to create a Node of type iFrame
, this would simplify the logic in that file.
src/components/Personalization/in-app-message-actions/actions/displayIframeContent.js
Outdated
Show resolved
Hide resolved
src/components/Personalization/in-app-message-actions/actions/displayIframeContent.js
Show resolved
Hide resolved
src/components/Personalization/in-app-message-actions/actions/displayIframeContent.js
Outdated
Show resolved
Hide resolved
src/components/Personalization/in-app-message-actions/actions/displayIframeContent.js
Outdated
Show resolved
Hide resolved
src/components/Personalization/in-app-message-actions/actions/displayIframeContent.js
Outdated
Show resolved
Hide resolved
src/components/Personalization/in-app-message-actions/actions/displayIframeContent.js
Outdated
Show resolved
Hide resolved
carterworks
reviewed
Oct 13, 2023
ninaceban
reviewed
Oct 16, 2023
ninaceban
reviewed
Oct 16, 2023
# Conflicts: # src/components/Personalization/createApplyPropositions.js # src/components/Personalization/createComponent.js # src/components/Personalization/createPendingNotificationsHandler.js # src/components/Personalization/createViewChangeHandler.js # src/components/Personalization/event.js # src/components/Personalization/index.js # test/unit/specs/components/Personalization/createComponent.spec.js # test/unit/specs/components/Personalization/createPendingNotificationsHandler.spec.js # test/unit/specs/components/Personalization/createViewChangeHandler.spec.js # test/unit/specs/components/Personalization/topLevel/buildAlloy.js
* use existing Alloy DOM utils * removed unused utils method * renamed to "test:unit:debug" * added a try/catch to handle potential JSON parsing errors * removed ensureSchemaBasedRulesetConsequences * using shorthand object property notation * new line * constants shared between components moved to the shared src/constants module * use alloy utils method includes * use alloy utils method values, objectOf * lint * removeElementById for readability --------- Co-authored-by: Jason Waters <[email protected]>
* support multi-subscription * support multi-subscription * remove mobile app fudge * support distinct emissions for each subscription with conditions * event.hasQuery() * values()
# Conflicts: # src/components/DataCollector/index.js # src/components/Personalization/createComponent.js # src/components/Personalization/createOnClickHandler.js # src/components/Personalization/createViewCacheManager.js # src/components/Personalization/event.js # src/components/Personalization/index.js # src/core/createEventManager.js # test/unit/specs/components/DataCollector/index.spec.js # test/unit/specs/components/Personalization/createComponent.spec.js # test/unit/specs/components/Personalization/topLevel/buildAlloy.js # test/unit/specs/core/createEventManager.spec.js
* config flag to enable storage in localStorage * based on consent set event registry * tests * for sandbox testing * fix after test * in-memory storage * tests * utils tests * use setStorage only --------- Co-authored-by: Jason Waters <[email protected]>
ninaceban
requested changes
Oct 26, 2023
src/components/Personalization/in-app-message-actions/actions/displayIframeContent.js
Outdated
Show resolved
Hide resolved
carterworks
reviewed
Oct 26, 2023
* few test * few test * few test * fix test
* using selectNodes, isNonEmptyArray, isNonEmptyString utils * using toArray * using createRedirect * using warning instead of error
carterworks
approved these changes
Oct 27, 2023
jonsnyder
approved these changes
Oct 27, 2023
ninaceban
approved these changes
Oct 27, 2023
jonsnyder
changed the title
In browser messages
Added support for rendering in-app messages from Adobe Journey Optimizer
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for In-app messages and message feed.
📺 Watch the demo!
Architecture docs
Sandbox demo pages
New dependencies
New components
New schemas
New commands
new Configuration options
Types of changes
Checklist: