Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be explicit about error conditions in DomAction and HtmlContent processors #1060

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

jonsnyder
Copy link
Contributor

@jonsnyder jonsnyder commented Oct 18, 2023

Description

This updates the DomAction and HTMLContent processors to be more explicit in how to handle items that are invalid. Namely it should not mark them rendered and not include them in the display notification.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

@jonsnyder jonsnyder merged commit dd2a632 into main Oct 19, 2023
2 of 3 checks passed
@jonsnyder jonsnyder deleted the explicitProcessors branch October 19, 2023 17:55
@jonsnyder jonsnyder added the ignore-for-release Do not include this PR in release notes label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Do not include this PR in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants