Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not send bottom of page events after a redirect #1066

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Do not send bottom of page events after a redirect #1066

merged 1 commit into from
Oct 27, 2023

Conversation

jonsnyder
Copy link
Contributor

Description

We found in testing that when running a top of page event with a redirect offer, the bottom of page event was still sent. This PR fixes that issue so that when there are sendEvent calls that are waiting for rendered propositions, they will not run when a redirect is executed.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

jfkhoury
jfkhoury approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@jfkhoury jfkhoury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smart solution. I’d love to see what Nina thinks but I like it. Can we think of any edge cases we can add to the functional tests?

@jonsnyder jonsnyder merged commit 735b663 into main Oct 27, 2023
2 of 3 checks passed
@jonsnyder jonsnyder deleted the fixRedirectBottomOfPageEvent branch October 27, 2023 04:39
@jonsnyder jonsnyder added the ignore-for-release Do not include this PR in release notes label Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carterworks carterworks carterworks approved these changes

@ninaceban ninaceban ninaceban approved these changes

@jfkhoury jfkhoury jfkhoury approved these changes

Assignees
No one assigned
Labels
ignore-for-release Do not include this PR in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonsnyder @jfkhoury @ninaceban @carterworks