Fixed an issue where bottom of page calls would never send when there was a top of page call with renderDecisions set to false. #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e multiple top of page calls.
carterworks
approved these changes
Jan 2, 2024
jfkhoury
reviewed
Jan 3, 2024
| if (!sendDisplayEvent) { | ||
| return (isRenderDecisions, isSendDisplayEvent, viewName) => { | ||
| if (!isRenderDecisions) { | ||
| // If we aren't rendering anything, then we don't need to sendDisplayEvents. |
jonsnyder
changed the title
jonsnyder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When you have a top of page call with renderDecisions: false, and sendDisplayEvent: false, the bottom of page call would never send. Daniel Wright found this bug. A work-around is to set renderDecisions: true whenever you have sendDisplayEvent: false.
Related Issue
https://jira.corp.adobe.com/browse/PDCL-11480
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: