Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional functional test and unit test for AJO content card feature #1169

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

shammowla
Copy link
Collaborator

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

const propositionId = uuid();
const itemId = uuid();

const responseBody = createMockResponse({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shammowla Now that Content Card is released in the UI, why are we still mocking the response?

@jonsnyder jonsnyder merged commit b1e255b into main Sep 5, 2024
5 checks passed
@jonsnyder jonsnyder deleted the ajo-test branch September 5, 2024 17:40
@jonsnyder jonsnyder added the ignore-for-release Do not include this PR in release notes label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Do not include this PR in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants