Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an issue where cookies were not included when running on localhost #1172

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

jonsnyder
Copy link
Contributor

Description

The change to drop IE support made a slight change in functionality. It caused localhost to be treated as using a first party collection domain.

  • On localhost the apexDomain is set to ""
  • Before dropping IE the test for first party domain was endsWith(endpointDomain, apexDomain). This returns false for endsWith("edge.adobedc.net", "")
  • After dropping IE, the test for first party domain was endpointDomain.endsWith(apexDomain). This returns true for "edge.adobedc.net".endsWith("")

This change adds a check for an empty apexDomain.

Related Issue

https://jira.corp.adobe.com/browse/PDCL-12457

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

@jonsnyder jonsnyder requested a review from dompuiu August 27, 2024 14:55
@dompuiu
Copy link
Member

dompuiu commented Aug 27, 2024

I approved it, but there is an error in Firefox where some cookies don't match.

@jonsnyder jonsnyder merged commit 7c8f950 into main Sep 5, 2024
4 of 5 checks passed
@jonsnyder jonsnyder deleted the fixLocalhostCookies branch September 5, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants