Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prod workflow artifact bug fix #1176

Merged
merged 4 commits into from
Sep 6, 2024
Merged

Prod workflow artifact bug fix #1176

merged 4 commits into from
Sep 6, 2024

Conversation

shammowla
Copy link
Collaborator

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

@shammowla shammowla requested a review from jonsnyder September 5, 2024 17:48
jonsnyder
jonsnyder approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@jonsnyder jonsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I was wondering why the artifacts weren't working.

@jonsnyder
Copy link
Contributor

You should be more descriptive for your commit messages.

@shammowla shammowla merged commit 9dcd39f into main Sep 6, 2024
21 of 36 checks passed
@shammowla shammowla deleted the ghactions-fix branch September 6, 2024 15:39
@jonsnyder jonsnyder added the ignore-for-release Do not include this PR in release notes label Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carterworks carterworks carterworks approved these changes

@jonsnyder jonsnyder jonsnyder approved these changes

Assignees
No one assigned
Labels
ignore-for-release Do not include this PR in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shammowla @jonsnyder @carterworks