WIP Priority Resolution #1193
Closed
WIP Priority Resolution #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsnyder
commented
Oct 7, 2024
| render().then( | ||
| handleNotifications.bind( | ||
| null, | ||
| returnedPropositions.filter((p) => p.isSuppressedDisplay), |
There was a problem hiding this comment.
I think these params are in the wrong order. See createNotificationHandler.js#L28
| @@ -30,13 +30,19 @@ export default ({ | |||
| const { render, returnedPropositions } = processPropositions( | |||
| propositionsToExecute, | |||
| ); | |||
| debugger; | |||
There was a problem hiding this comment.
Remember to remove this
| ); | ||
| } | ||
|
|
||
| debugger; |
There was a problem hiding this comment.
Remember to remove
| : null, | ||
| setRenderAttempted: firstItemInBatch, | ||
| setSuppressedDisplay: !firstItemInBatch, | ||
| includeInNotification: firstItemInBatch, |
There was a problem hiding this comment.
I was under the impression that we should only be rendering the last item.
|
Closed in favor of Jason's branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: