Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When multiple in-app messages are returned, only the one with the highest priority is shown. The others are recorded as suppressed #1194

Merged
merged 14 commits into from
Oct 28, 2024
Merged

When multiple in-app messages are returned, only the one with the highest priority is shown. The others are recorded as suppressed #1194

merged 14 commits into from
Oct 28, 2024

Conversation

dompuiu
Copy link
Member

@dompuiu dompuiu commented Oct 8, 2024

Description

This PR is rendering on the page the In-App message with the highest rank. For the others that are not shown, a suppressDisplay event is sent back.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

ninaceban
ninaceban approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@ninaceban ninaceban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dompuiu dompuiu merged commit 3f64390 into main Oct 28, 2024
4 of 6 checks passed
@dompuiu dompuiu deleted the PDCL-12483-waters branch October 28, 2024 21:47
@jonsnyder jonsnyder changed the title PDCL-12483 Add conflict resolution support for In-App messages. When multiple in-app messages are returned, only the one with the highest priority is shown. The others are recorded as suppressed Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carterworks carterworks carterworks left review comments

@ninaceban ninaceban ninaceban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dompuiu @ninaceban @carterworks @jasonwaters