Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Fallback for Blocked demdex.net Requests #1210

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Conversation

shammowla
Copy link
Collaborator

Summary

Added fallback mechanism to use configured edge domain when demdex.net requests fail. This improves reliability when users have ad blockers or network restrictions that block third-party endpoints.

Changes

  • Added detection of demdex.net failures in network requests
  • Implemented fallback to edge domain
  • Added test coverage

Testing

Verified behavior with:

  • New functional test suite (demdexFallback.js)
  • Updated existing tests (C10922.js)

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

@shammowla shammowla merged commit e6d4f5a into main Nov 5, 2024
4 of 6 checks passed
@shammowla shammowla deleted the PDCL-8332 branch November 5, 2024 16:32
@shammowla shammowla restored the PDCL-8332 branch November 6, 2024 15:13
shammowla added a commit that referenced this pull request Nov 8, 2024
shammowla added a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants