Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup #1217

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Cleanup #1217

merged 1 commit into from
Nov 20, 2024

Conversation

ninaceban
Copy link
Contributor

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

@carterworks carterworks added the ignore-for-release Do not include this PR in release notes label Nov 12, 2024
jonsnyder
jonsnyder approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@jonsnyder jonsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always good to remove unused code.

@ninaceban ninaceban merged commit 631e067 into main Nov 20, 2024
4 of 5 checks passed
@ninaceban ninaceban deleted the clean-up branch November 20, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carterworks carterworks carterworks approved these changes

@jonsnyder jonsnyder jonsnyder approved these changes

Assignees
No one assigned
Labels
ignore-for-release Do not include this PR in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ninaceban @jonsnyder @carterworks