Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unit tests to vitest. #1224

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Move unit tests to vitest. #1224

wants to merge 11 commits into from

Conversation

dompuiu
Copy link
Member

@dompuiu dompuiu commented Jan 8, 2025

Description

Karma is deprecated. SauceLabs was not reliable on running tests. We move the unit tests to vitest.

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA or I'm an Adobe employee.
  • I have made any necessary test changes and all tests pass.
  • I have run the Sandbox successfully.

dompuiu added 10 commits January 8, 2025 14:04
Add script that converts tests from jasmine to vitest.

Some changes created by linting fix.

New tests for vitest.

Fix test.

Fix lint error.

New batch updated.

Undo the changes to the test and add it to the browser suite.

Run browser in headless mode.

Improve test speed.

New batch.

New batch.

Last batch converted.

Fix some flaky tests.
Change properties order.
Remove workspace config.

Rename tests suite.
Remove karma config.
@dompuiu
Copy link
Member Author

dompuiu commented Jan 8, 2025

The unit tests now pass on Github Actions. You can check the results of the Alloy Dev / Unit Test (pull_request) check on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant