Added propositions option to sendEvent command to make display notifications easier #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterworks
approved these changes
May 5, 2023
| if (propositions && propositions.length > 0) { | ||
| const propositionEventType = | ||
| event.getEventType() === "decisioning.propositionInteract" || | ||
| event.getPropositionEventType() === "interact" |
There was a problem hiding this comment.
(non-blocking nitpick) Change this to PropositionEventType.DISPLAY and PropositionEventType.INTERACT from src/components/Personalization/constants/propositionEventType.js.
| ({ id, scope, scopeDetails }) => ({ id, scope, scopeDetails }) | ||
| ), | ||
| propositionEventType: { | ||
| [propositionEventType]: 1 |
| ); | ||
| }); | ||
| }); | ||
| // TODO |
There was a problem hiding this comment.
What is this TODO for? Is it "write a process destinations test?" Why was this test removed?
ninaceban
requested changes
Jun 13, 2023
|
Closed in favor of #1036 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a propositions option to the sendEvent command. This will be useful when doing top of page and bottom of page calls as it allows you to include the display notification along with the page view at the bottom of the page.
Related Issue
Motivation and Context
Screenshots (if appropriate):
Types of changes
Checklist: