Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use window.view before it's initialized. #206

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Don't use window.view before it's initialized. #206

merged 1 commit into from
Sep 9, 2024

Conversation

bosschaert
Copy link
Contributor

Description

After updating da-y-wrapper timing of certain callbacks have changed which lead to #200

window.view is used by callbacks given to EditorState and EditorView in their constructors and called before these constructors return. Previously it seems that Prosemirror was making these callbacks later.

Related Issue

Fixes #200

Motivation and Context

To be able to regenerate (and extend) da-y-wrapper.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

aem-code-sync bot commented Sep 9, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@auniverseaway auniverseaway merged commit 7ec9e67 into main Sep 9, 2024
4 of 6 checks passed
@auniverseaway auniverseaway deleted the tchg branch September 9, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-generating da-y-wrapper causes error in the browser
2 participants