Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle section breaks when pasting text from other sources #210

Merged
merged 10 commits into from
Sep 12, 2024
Merged

Conversation

bosschaert
Copy link
Contributor

Description

Convert triple dashes on a line by itself to a section break.
Also handle Word-specific section breaks when pasted from Word online or desktop Word.

Related Issue

Fixes: #209

Motivation and Context

"I would like the ability to copy Word-formatted section breaks and have DA convert them to HRs so I do not have to reformat docs coming from other sources."

How Has This Been Tested?

Tested on https://dashes--da-live--adobe.hlx.live/

Unit tests to come.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

aem-code-sync bot commented Sep 11, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Sep 11, 2024

Page Scores Audits Google
M / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@bosschaert
Copy link
Contributor Author

I intend to add tests for this code separately.

@auniverseaway auniverseaway merged commit 499103e into main Sep 12, 2024
5 of 6 checks passed
@auniverseaway auniverseaway deleted the dashes branch September 12, 2024 03:14
auniverseaway added a commit that referenced this pull request Sep 12, 2024
auniverseaway added a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Triple dash support
2 participants